From 9228f232484306bc849d844f36fcb2eaaac9fb76 Mon Sep 17 00:00:00 2001 From: mmi Date: Thu, 16 Nov 2017 14:07:46 +0000 Subject: [PATCH] Added buglist to generate release notes Fixed bug with PIN CHANGE VERIFICATION. All pins were accepted. is fixed now git-svn-id: https://svn.vbchaos.nl/svn/hsb/trunk@279 05563f52-14a8-4384-a975-3d1654cca0fa --- .../3 - Implementation/0 - Code/buglist.txt | 6 ++++++ .../3 - Implementation/0 - Code/hsb-mrts/src/PIN.c | 3 +-- 2 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 S - Software/0 - HSB MRTS Kathode-MCP/3 - Implementation/0 - Code/buglist.txt diff --git a/S - Software/0 - HSB MRTS Kathode-MCP/3 - Implementation/0 - Code/buglist.txt b/S - Software/0 - HSB MRTS Kathode-MCP/3 - Implementation/0 - Code/buglist.txt new file mode 100644 index 0000000..60cb585 --- /dev/null +++ b/S - Software/0 - HSB MRTS Kathode-MCP/3 - Implementation/0 - Code/buglist.txt @@ -0,0 +1,6 @@ +- PIN change verification not functional +- Display backlight unstable +- Display cursor unstable +- HW validation menu outdated/unfunctional +- NumberOfStages Macro for presets not implemented well. It will be ignored when generating DEFAULT presets +- repairMenu has bad reference to getmainrepairmenu \ No newline at end of file diff --git a/S - Software/0 - HSB MRTS Kathode-MCP/3 - Implementation/0 - Code/hsb-mrts/src/PIN.c b/S - Software/0 - HSB MRTS Kathode-MCP/3 - Implementation/0 - Code/hsb-mrts/src/PIN.c index 59dc514..3434cca 100644 --- a/S - Software/0 - HSB MRTS Kathode-MCP/3 - Implementation/0 - Code/hsb-mrts/src/PIN.c +++ b/S - Software/0 - HSB MRTS Kathode-MCP/3 - Implementation/0 - Code/hsb-mrts/src/PIN.c @@ -25,7 +25,6 @@ // Include files // ----------------------------------------------------------------------------- -#include #include #include "PIN.h" @@ -133,7 +132,7 @@ static ErrorStatus PIN_verifyInsertedPins(struct PIN* self) { ErrorStatus returnValue = SUCCESS; - if(memcmp(self->pinchangeFirstInsert, self->pinchangeSecondInsert, PIN_NUMBER_OF_DIGITS != 0)) + if(strncmp(self->pinchangeFirstInsert, self->pinchangeSecondInsert, PIN_NUMBER_OF_DIGITS) != 0) { // Inserted PINs are not equal returnValue = ERROR;